-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hoist toSequenceExpression's convert helper #5693
Conversation
@jridgewell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @boopathi and @zertosh to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #5693 +/- ##
=========================================
+ Coverage 84.72% 84.8% +0.07%
=========================================
Files 204 204
Lines 9600 9603 +3
Branches 2697 2700 +3
=========================================
+ Hits 8134 8144 +10
+ Misses 978 975 -3
+ Partials 488 484 -4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5693 +/- ##
==========================================
+ Coverage 84.72% 84.77% +0.04%
==========================================
Files 204 204
Lines 9600 9603 +3
Branches 2697 2700 +3
==========================================
+ Hits 8134 8141 +7
Misses 978 978
+ Partials 488 484 -4
Continue to review full report at Codecov.
|
8aee10c
to
f265860
Compare
Oh dang this was on master haha.. |
Whoops, I'll port it over. |
Hoist toSequenceExpression's convert helper (#5693)
Like it says. Also fixes two bugs when recursing into
IfStatement
s orBlockStatement
s that themselves bail.