-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ObjectProperty patterns #5762
Conversation
@citycide, thanks for your PR! By analyzing the history of the files in this pull request, we identified @existentialism, @hzoo and @phantom10111 to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## 7.0 #5762 +/- ##
==========================================
- Coverage 84.63% 84.62% -0.02%
==========================================
Files 282 282
Lines 9854 9854
Branches 2766 2766
==========================================
- Hits 8340 8339 -1
- Misses 1000 1001 +1
Partials 514 514
Continue to review full report at Codecov.
|
Awesome! Can we add a passing test too? https://github.com/babel/babel/blob/master/packages/babel-types/test/validators.js |
Added a test that includes uses of both the object pattern & the array pattern - let me know if there's any issues with the structure of that test, there just isn't a lot to reference in there yet 😆 |
Nope sounds good to me! (just need a test to check that it's not failing) |
Add
Pattern
s to theObjectProperty
validator to fix nested patterns. #5722 has already been merged to fixArrayPattern
s.Also add
RestElement
to allow object rest to appear.Target case: