Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Alpha 12 #5808

Merged
merged 2 commits into from Jun 1, 2017

Conversation

@hzoo
Copy link
Member

hzoo commented Jun 1, 2017

(node:79847) DeprecationWarning: Passing lineNumber and colNumber is deprecated to babel-code-frame. Please use codeFrameColumns 😅

@hzoo hzoo changed the title Alpha 11 ⬆️ Alpha 12 Jun 1, 2017
@hzoo hzoo force-pushed the alpha-11 branch from f1cfbe0 to ec9670a Jun 1, 2017
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 1, 2017

Codecov Report

Merging #5808 into 7.0 will decrease coverage by 0.05%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              7.0    #5808      +/-   ##
==========================================
- Coverage   84.91%   84.86%   -0.06%     
==========================================
  Files         284      284              
  Lines        9928     9928              
  Branches     2788     2787       -1     
==========================================
- Hits         8430     8425       -5     
- Misses        988      990       +2     
- Partials      510      513       +3
Impacted Files Coverage Δ
packages/babel-traverse/src/path/replacement.js 82.45% <0%> (-0.73%) ⬇️
...ckages/babel-core/src/transformation/file/index.js 87.2% <100%> (+0.05%) ⬆️
packages/babel-code-frame/src/index.js 88.34% <0%> (-5.83%) ⬇️
packages/babel-traverse/src/visitors.js 85.71% <0%> (-0.96%) ⬇️
packages/babel-traverse/src/path/context.js 86.2% <0%> (ø) ⬆️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.98% <0%> (+0.34%) ⬆️
packages/babel-traverse/src/path/modification.js 73.07% <0%> (+0.96%) ⬆️
packages/babel-helper-call-delegate/src/index.js 68% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e739f9...ec9670a. Read the comment docs.

@hzoo hzoo merged commit 272209a into 7.0 Jun 1, 2017
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 84.86% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
const location = {
start: {
line: loc.line,
column: loc.column + 1,

This comment has been minimized.

Copy link
@SimenB

SimenB Jun 1, 2017

Contributor

This sucks... Is the +1 expected?

This comment has been minimized.

Copy link
@hzoo

hzoo Jun 1, 2017

Author Member

Oh? in our code it was +1 already? I just copied it over

This comment has been minimized.

Copy link
@SimenB

SimenB Jun 1, 2017

Contributor

I'm thinking it should just work ™️ with existent AST loc objects. That was the point.

This comment has been minimized.

Copy link
@hzoo

hzoo Jun 1, 2017

Author Member

We don't have any tests for it probably so I didn't really check, dono if you want to take a look

@SimenB

This comment has been minimized.

Copy link
Contributor

SimenB commented Jun 2, 2017

still calls deprecated method: #5815

@hzoo hzoo deleted the alpha-11 branch Jun 9, 2017
@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.