Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numeric separator Number transform #5825

Merged
merged 1 commit into from
Jun 6, 2017

Conversation

jridgewell
Copy link
Member

Q A
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Deprecations? No
Spec Compliancy? Yes?
Tests Added/Pass? Yes
Fixed Tickets
License MIT
Doc PR
Dependency Changes

The transform assumed the argument to Number was always a string, which isn't correct. Now, we only remove the separators if it is in fact a string.

@jridgewell jridgewell added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jun 6, 2017
@codecov
Copy link

codecov bot commented Jun 6, 2017

Codecov Report

Merging #5825 into 7.0 will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              7.0    #5825      +/-   ##
==========================================
- Coverage   84.95%   84.89%   -0.07%     
==========================================
  Files         284      284              
  Lines        9933     9934       +1     
  Branches     2781     2789       +8     
==========================================
- Hits         8439     8433       -6     
- Misses        982      991       +9     
+ Partials      512      510       -2
Impacted Files Coverage Δ
...el-plugin-transform-numeric-separator/src/index.js 100% <100%> (ø) ⬆️
packages/babel-helper-fixtures/src/index.js 71.62% <0%> (-4.06%) ⬇️
packages/babel-helper-call-delegate/src/index.js 64% <0%> (-4%) ⬇️
packages/babel-traverse/src/path/context.js 85.34% <0%> (-1.73%) ⬇️
packages/babel-traverse/src/path/modification.js 72.11% <0%> (-0.97%) ⬇️
packages/babel-traverse/src/visitors.js 85.71% <0%> (-0.96%) ⬇️
packages/babel-types/src/definitions/es2015.js 96.15% <0%> (-0.52%) ⬇️
packages/babel-types/src/definitions/core.js 98.21% <0%> (-0.32%) ⬇️
...in-transform-es2015-template-literals/src/index.js 100% <0%> (ø) ⬆️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.63% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 123dce5...388d4fb. Read the comment docs.

Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hzoo hzoo merged commit 8df5514 into babel:7.0 Jun 6, 2017
@hzoo
Copy link
Member

hzoo commented Jun 6, 2017

Nice work, super quick @jridgewell!

@hzoo
Copy link
Member

hzoo commented Jun 6, 2017

Oh yeah, and cc @rwaldron (and please accept Babel org inv)

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants