Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass SIGINT signals to the spawned child process #5861

Merged
merged 4 commits into from
Jun 24, 2017

Conversation

bill-improbableio
Copy link
Contributor

@bill-improbableio bill-improbableio commented Jun 15, 2017

Q A
Patch: Bug Fix? yes
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? yes (?)
Tests Added/Pass? yes
Fixed Tickets Fixes #1062
License MIT
Doc PR no
Dependency Changes no

Fixes an issue where SIGINT was not passed to the running child process when a script was started using babel-node.

NOTE: this issue does not manifest if kexec is installed as a dependency.

See #1062

@codecov
Copy link

codecov bot commented Jun 15, 2017

Codecov Report

Merging #5861 into 7.0 will increase coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              7.0    #5861      +/-   ##
==========================================
+ Coverage   85.25%   85.25%   +<.01%     
==========================================
  Files         284      284              
  Lines        9963     9966       +3     
  Branches     2781     2781              
==========================================
+ Hits         8494     8497       +3     
  Misses        969      969              
  Partials      500      500
Impacted Files Coverage Δ
packages/babel-cli/src/babel-node.js 46% <33.33%> (-0.81%) ⬇️
packages/babel-traverse/src/path/context.js 86.2% <0%> (ø) ⬆️
...bel-plugin-transform-es2015-classes/src/vanilla.js 91.06% <0%> (+0.42%) ⬆️
packages/babel-traverse/src/visitors.js 86.66% <0%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5387d9f...45e2a4c. Read the comment docs.

@hzoo
Copy link
Member

hzoo commented Jun 24, 2017

Oh, now I wonder why it's not a dependency then, or was it meant to be optional?

@jridgewell
Copy link
Member

kexec can't be installed on all systems.

@hzoo hzoo merged commit 851d2cb into babel:7.0 Jun 24, 2017
@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jun 24, 2017
@oliviertassinari
Copy link
Contributor

oliviertassinari commented Jan 26, 2018

Side note: this logic is no longer present in v7.x.

@davidfraser
Copy link

@oliviertassinari is right - src/babel-node.js was moved from packages/babel-cli to packages/babel-node by @existentialism in 6d965c0 (see #6023), but lost this code, which was still present when it was removed from packages/babel-cli in 2374062 (see src/babel-node.js#L103)

davidfraser pushed a commit to davidfraser/processfamily that referenced this pull request Mar 6, 2018
This is useful for running babel-node where it does not currently pass the signal down to the child it spawns
See babel/babel#5861
@existentialism
Copy link
Member

@oliviertassinari @davidfraser thanks, opened #7511!

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants