Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5768 (to 7.0 branch) #5891

Merged
merged 1 commit into from Jun 28, 2017
Merged

Fix 5768 (to 7.0 branch) #5891

merged 1 commit into from Jun 28, 2017

Conversation

@joshwnj
Copy link
Contributor

joshwnj commented Jun 27, 2017

Q A
Patch: Bug Fix? yes
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? yes
Tests Added/Pass? yes
Fixed Tickets Fixes #5768
License MIT
Doc PR no
Dependency Changes no

This introduces the same changes as merged in #5811, but targets 7.0 instead of master.

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Jun 27, 2017

@joshwnj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjamn, @existentialism and @hzoo to be potential reviewers.

@joshwnj joshwnj mentioned this pull request Jun 27, 2017
@hzoo hzoo merged commit bc29145 into babel:7.0 Jun 28, 2017
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 85.71% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Jun 28, 2017

👍 thanks!

@joshwnj joshwnj deleted the joshwnj:fix-5768-2 branch Jun 28, 2017
@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Aug 4, 2017

Ok found a regression (and making a fix) with this PR

@hzoo hzoo mentioned this pull request Aug 4, 2017
@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.