Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove codecov node package and use bash uploader #5937

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Remove codecov node package and use bash uploader #5937

merged 1 commit into from
Jul 11, 2017

Conversation

danez
Copy link
Member

@danez danez commented Jul 11, 2017

Q A
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? n
Deprecations? n
Spec Compliancy? n
Tests Added/Pass? y
Fixed Tickets
License MIT
Doc PR
Dependency Changes y

The codecov package uses the outdated execSync.

Also use carrets for dependency versions

@danez danez added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jul 11, 2017
@danez
Remove codecov node package and use bash uploader
917fde0 
This prevents codecov installing outdated dependencies (execSync)

Also use carrets for dependency versions
jridgewell
jridgewell approved these changes Jul 11, 2017
View reviewed changes
Copy link
Member

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please backport to 6.0, too.

@existentialism existentialism merged commit 2ce5f16 into babel:7.0 Jul 11, 2017
@existentialism existentialism mentioned this pull request Jul 11, 2017
Merged
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danez @existentialism @jridgewell