Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed update operators from number unary operators #5940

Merged
merged 1 commit into from
Jul 12, 2017
Merged

Removed update operators from number unary operators #5940

merged 1 commit into from
Jul 12, 2017

Conversation

maurobringolf
Copy link
Contributor

Q A
Patch: Bug Fix? Yes?
Major: Breaking Change? No
Minor: New Feature? No
Deprecations? No
Spec Compliancy? No
Tests Added/Pass? No/Yes
Fixed Tickets
License MIT
Doc PR
Dependency Changes

I discovered that the docs of babel-types on the website have a small mistake: UnaryExpression allows update operators ++ and --. But these are already covered by the UpdateExpression node. I was told by @jridgewell to remove them here in order for correct documentation to be generated.

@existentialism existentialism added pkg: types PR: Docs 📝 A type of pull request used for our changelog categories labels Jul 11, 2017
@@ -43,7 +43,7 @@ export const BINARY_OPERATORS = [
];

export const BOOLEAN_UNARY_OPERATORS = ["delete", "!"];
export const NUMBER_UNARY_OPERATORS = ["+", "-", "++", "--", "~"];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also a breaking change haha

Copy link
Member

@jridgewell jridgewell Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why we're in alphas. I'd be surprised if anyone actually used this, though.

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants