Fix react-inline-elements bug #5958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jridgewell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @spicyj and @existentialism to be potential reviewers. |
sarupbanskota
approved these changes
Jul 17, 2017
hzoo
reviewed
Jul 17, 2017
| @@ -16,7 +16,7 @@ export default function({ types: t }) { | |||
|
|
|||
| function getAttributeValue(attr) { | |||
| let value = attr.value; | |||
| if (!value) return t.identifier("true"); | |||
There was a problem hiding this comment.
! maybe worth making a linting rule for this haha?
There was a problem hiding this comment.
I have a huge update to the type system that'll catch these.
hzoo
added
the
PR: Bug Fix 🐛
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one's obviously a bug. You can't have
trueidentifier, only a boolean literal.