Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for-of loose optimization #5964

Merged
merged 1 commit into from Jul 18, 2017
Merged

Fix for-of loose optimization #5964

merged 1 commit into from Jul 18, 2017

Conversation

@jridgewell
Copy link
Member

jridgewell commented Jul 18, 2017

Q A
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Deprecations? No
Spec Compliancy? No
Tests Added/Pass? No
Fixed Tickets
License MIT
Doc PR
Dependency Changes

VariableDeclarators can’t have a MemberExpression id.

VariableDeclarators can’t have a MemberExpression id.
@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Jul 18, 2017

@jridgewell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @existentialism and @loganfsmyth to be potential reviewers.

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Jul 18, 2017

Did you have a test case for this?

@jridgewell

This comment has been minimized.

Copy link
Member Author

jridgewell commented Jul 18, 2017

No, it would always just work. But it worked because babel-types is pretty loose with what's allowed in VariableDeclarator.id, and my babel-types update will break that.

@hzoo
hzoo approved these changes Jul 18, 2017
@hzoo hzoo merged commit 8a5488e into babel:7.0 Jul 18, 2017
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 85.76% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.