allow PluginPass.file.addImport to create empty import statements #6022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#6021 omitting addImport's second argument creates an import statement with an empty `specifiers` array i.e. an empty import statement: plugin: Program (path, { file }) { file.addImport('foo-bar/register') } output: import "foo-bar/register";
jridgewell
approved these changes
Jul 27, 2017
existentialism
added
the
PR: Bug Fix 🐛
existentialism
approved these changes
Jul 28, 2017
|
Awesome!! nice work here (and we should add this method to the handbook in a section if someone wants to do that) Ah I see you wanted this for https://github.com/chocolateboy/babel-plugin-source-map-support/blob/master/src/plugin.js, which is what babel-register adds as well. |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omitting
addImport's second argument creates an import statement with an emptyspecifiersarray i.e. an empty import statement:plugin
output