Fix invalid block-scoped loop #6046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
added
the
PR: Bug Fix 🐛
|
@jridgewell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @existentialism and @loganfsmyth to be potential reviewers. |
hzoo
reviewed
Aug 3, 2017
| const args = values(outsideRefs); | ||
| const params = args.map(id => t.clone(id)); |
There was a problem hiding this comment.
Wondering, are there other places we would need to make this change (where we don't clone)? and how we can prevent this issue in the future (other than the whole immutable ast)
|
Awesome fix! |
This was referenced Aug 3, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is we're reusing the same identifier in two scopes (in as the hoisted loop's function params, and as that function's call expression arguments). Well, when we remap in the context of the loop call, we changed the param's name, too.