Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parser plugin from babel-preset-typescript to babel-plugin-syntax-typescript #6070

Merged
merged 1 commit into from Aug 8, 2017
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2017

Q A
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Deprecations? No
Spec Compliancy? No
Tests Added/Pass? Tests pass
Fixed Tickets #5899 (comment)
License MIT
Doc PR
Dependency Changes Yes, a dependency is removed

If this is merged, I will make a PR to babylon removing the special handling for TypeScript in https://github.com/babel/babylon/blob/c88af90c0a88ec756ad7c27f0a1c6f92bffbcd24/src/parser/statement.js#L1148.

@mention-bot
Copy link

@andy-ms, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo to be a potential reviewer.

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this sounds good to me!

@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Aug 8, 2017
@existentialism existentialism merged commit 1c1ce5a into babel:7.0 Aug 8, 2017
@ghost ghost deleted the syntax-typescript branch August 8, 2017 21:02
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants