New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numeric separator to stage 2 preset #6071

Merged
merged 1 commit into from Aug 10, 2017

Conversation

Projects
None yet
2 participants
@rwaldron
Contributor

rwaldron commented Aug 8, 2017

Q A
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Deprecations? No
Spec Compliancy? Yes
Tests Pass? Yes
Fixed Tickets
License MIT
Doc PR
Dependency Changes "babel-plugin-transform-numeric-separator" moves from stage 1 to stage 2
@hzoo

This comment has been minimized.

Member

hzoo commented Aug 8, 2017

Will also need to change the index.js file in both*

Moving up stages shouldn't be breaking because stage-0 includes stage-1 etc

something like 5492fe1

@hzoo hzoo referenced this pull request Aug 8, 2017

Closed

July 2017 #19

10 of 10 tasks complete
@rwaldron

This comment has been minimized.

Contributor

rwaldron commented Aug 10, 2017

Will also need to change the index.js file in both*

lol, I'm embarrassed to even try to explain why I think I missed/forgot this ;) Thanks for being patient with me :D

Moving up stages shouldn't be breaking because stage-0 includes stage-1 etc

ok, got it!

@hzoo hzoo added the Priority: High label Aug 10, 2017

@hzoo hzoo merged commit 9c91e35 into babel:7.0 Aug 10, 2017

1 of 2 checks passed

ci/circleci Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hzoo

This comment has been minimized.

Member

hzoo commented Aug 10, 2017

Cool thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment