Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow substrings for TEST_ONLY in make #6079

Merged
merged 1 commit into from Aug 10, 2017

Conversation

@Qantas94Heavy
Copy link
Member

Qantas94Heavy commented Aug 9, 2017

Q A
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? no
Tests Added/Pass? N/A
Fixed Tickets
License MIT
Doc PR
Dependency Changes

This allows TEST_ONLY to match substrings of the package directory name instead of having to use the full package directory name.

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Aug 9, 2017

Can you add an example? If it's helpful we should update the contributing docs too then to account for this 👍 https://github.com/babel/babel/blob/7.0/CONTRIBUTING.md#running-lintingtests

@xtuc xtuc added the area: tests label Aug 9, 2017
Copy link
Member

jridgewell left a comment

👏

@hzoo
hzoo approved these changes Aug 9, 2017
Copy link
Member

hzoo left a comment

This allows TEST_ONLY to match substrings of the package directory name
instead of having to use the full package directory name.
@Qantas94Heavy Qantas94Heavy force-pushed the Qantas94Heavy:make-test-only-substr branch from 78d2755 to 89a7f99 Aug 10, 2017
@Qantas94Heavy

This comment has been minimized.

Copy link
Member Author

Qantas94Heavy commented Aug 10, 2017

@hzoo done

@hzoo hzoo merged commit 3a55e13 into babel:7.0 Aug 10, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
ci/circleci Your tests failed on CircleCI
Details
@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.