Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow substrings for TEST_ONLY in make #6079

Merged
merged 1 commit into from
Aug 10, 2017

Conversation

Qantas94Heavy
Copy link
Member

Q A
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? no
Tests Added/Pass? N/A
Fixed Tickets
License MIT
Doc PR
Dependency Changes

This allows TEST_ONLY to match substrings of the package directory name instead of having to use the full package directory name.

@hzoo
Copy link
Member

hzoo commented Aug 9, 2017

Can you add an example? If it's helpful we should update the contributing docs too then to account for this 👍 https://github.com/babel/babel/blob/7.0/CONTRIBUTING.md#running-lintingtests

@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Aug 9, 2017
Copy link
Member

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows TEST_ONLY to match substrings of the package directory name
instead of having to use the full package directory name.
@Qantas94Heavy
Copy link
Member Author

@hzoo done

@hzoo hzoo merged commit 3a55e13 into babel:7.0 Aug 10, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants