babel-plugin-transform-class-properties: Ignore type annotations when looking for name collisions #6082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… looking for name collisions
|
@andy-ms, thanks for your PR! By analyzing the history of the files in this pull request, we identified @existentialism, @hzoo and @motiz88 to be potential reviewers. |
hzoo
added
the
PR: Bug Fix 🐛
Yeah maybe we should remove that behavior, ends up being more annoying to deal with |
xtuc
approved these changes
Aug 11, 2017
ghost
deleted the
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip
TypeAnnotationnodes when looking for name collisions. This avoids unnecessary calls to_initialiseProps.Note: I had to put the test in its own directory because otherwise it would inherit plugins from its parent directory's options, and I needed to compile to a class to reproduce this problem.