Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-plugin-transform-class-properties: Ignore type annotations when looking for name collisions #6082

Merged
merged 1 commit into from Aug 11, 2017

Conversation

@andy-ms
Copy link
Contributor

andy-ms commented Aug 9, 2017

Q A
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Deprecations? No
Spec Compliancy? No
Tests Added/Pass? Yes
Fixed Tickets
License MIT
Doc PR
Dependency Changes No

Skip TypeAnnotation nodes when looking for name collisions. This avoids unnecessary calls to _initialiseProps.
Note: I had to put the test in its own directory because otherwise it would inherit plugins from its parent directory's options, and I needed to compile to a class to reproduce this problem.

… looking for name collisions
@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Aug 9, 2017

@andy-ms, thanks for your PR! By analyzing the history of the files in this pull request, we identified @existentialism, @hzoo and @motiz88 to be potential reviewers.

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Aug 10, 2017

Note: I had to put the test in its own directory because otherwise it would inherit plugins from its parent directory's options

Yeah maybe we should remove that behavior, ends up being more annoying to deal with

@hzoo
hzoo approved these changes Aug 10, 2017
Copy link
Member

hzoo left a comment

lgtm, dono if it conflicts with #6076 when merging

@xtuc
xtuc approved these changes Aug 11, 2017
@existentialism existentialism merged commit 9243c78 into babel:7.0 Aug 11, 2017
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 86.15% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@andy-ms andy-ms deleted the andy-ms:class-property-type branch Aug 11, 2017
Jessidhia referenced this pull request Aug 12, 2017
Diogo Franco (Kovensky)
@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.