Fixed loose option of transform-es2015-parameters handling only Assig… #6274
Conversation
existentialism
added
the
PR: Bug Fix 🐛
|
@Andarist awesome! was just looking into this :) |
|
hah, thats the reason why I was poking around about babel-preset-env on the slack ;) |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/4987/ |
|
|
||
| for (let i = 0; i < params.length; i++) { | ||
| const param = params[i]; | ||
|
|
||
| if (param.isAssignmentPattern()) { | ||
| if (param.isAssignmentPattern() && loose) { |
There was a problem hiding this comment.
Worth merging this with the next block that also wants isAssignmentPattern/left/right?
There was a problem hiding this comment.
well, i though about merging those 2 conditions, just couldnt stand the level of indentation it would have created ;) ive also wanted to extract it to some function for the readability but those blocks need access to just too many variables available in the scope
if you prefer I merge them just let me know and I'll amend my PR
There was a problem hiding this comment.
Yeah, had the same reservations re: nesting lol, it's fine.
lock
bot
added
the
outdated
…nmentPatterns
Fixed issue with introduced to
transform-es2015-parameters"loose" mode. It was handling only the AssignmentPatterns, so other parameters type introduced in es2015 like ObjectPatterns were not transformed at all.