Upgrade selfhosted compilation to beta.2 #6318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
requested changes
Sep 26, 2017
| @@ -33,7 +33,9 @@ export default function({ types: t }) { | |||
| const isUnderHelper = path.findParent(path => { | |||
| return ( | |||
| (path.isVariableDeclarator() && path.node.id === helper) || | |||
| (path.isFunctionDeclaration() && path.node.id.name === helper.name) | |||
There was a problem hiding this comment.
We need this for instanceof, too.
loganfsmyth
force-pushed
the
upgrade-selfhosted-version
branch
from
a288318
to
72054ba
Compare
jridgewell
approved these changes
Sep 26, 2017
|
Okay this is blocked on istanbuljs/istanbuljs#92 |
loganfsmyth
force-pushed
the
upgrade-selfhosted-version
branch
from
a2f5d9b
to
55c598c
Compare
|
Gonna close until we get the coverage bug fixed. |
loganfsmyth
changed the title
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typeof-symboltransform that I introduced in https://github.com/babel/babel/pull/5706/files#diff-08e96049279b483e87c80d84a7de5166R36