Fix runtime helpers generator #6366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Internal 🏠
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5145/ |
loganfsmyth
reviewed
Oct 2, 2017
| @@ -107,7 +107,8 @@ function buildHelper(helperName, modules, useBuiltIns) { | |||
| : null; | |||
| const sourceType = modules === "commonjs" ? "script" : "module"; | |||
|
|
|||
| const tree = t.program(helpers.get(helperName, id).nodes, [], sourceType); | |||
| const helper = helpers.get(helperName, null, id); | |||
| const tree = t.program(helper.nodes, [], sourceType); | |||
There was a problem hiding this comment.
This should have a getDependency callback to insert require calls for the imported helper, for the ES5 helper files.
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug introduced by the helpers dependencies PR