Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peerDep on specific babel-core version in transform plugins, pres… #6549

Merged
merged 1 commit into from
Oct 25, 2017

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Oct 24, 2017

…ets, and cli

Q                       A
Fixed Issues? Fixes #6539
Minor: New Feature? 👍
Any Dependency Changes? peer Deps

@hzoo hzoo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Oct 24, 2017
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5471/

@hzoo hzoo added this to the Babel 7.next milestone Oct 24, 2017
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Oct 24, 2017

Is there a way to say "babel-runtime must either be null or 7.0.0-beta.3"? Ok, there isn't (npm/npm#3066).

Since this PR is only about babel-core, it looks good to me.

@Jessidhia
Copy link
Member

Jessidhia commented Oct 25, 2017

This does mean that every single package has to be released in lockstep 🤔

But I assume this problem will be gone once we decide on API stability?

EDIT: I'm being silly and this is what actually allows "conflicting" versions to be used if you really need to

@hzoo
Copy link
Member Author

hzoo commented Oct 25, 2017

Ya after release it won't be beta only and we can use ^ or something

@hzoo hzoo merged commit e3cebbf into master Oct 25, 2017
@hzoo hzoo mentioned this pull request Oct 27, 2017
7 tasks
@hzoo hzoo deleted the peerDeps branch October 30, 2017 19:52
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 1, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta: adding peerDependencies on babel-core
7 participants