Make syntax highlighting for @ and # nicer
#6550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5472/ |
1 similar comment
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5472/ |
jridgewell
approved these changes
Oct 24, 2017
|
Maybe this should be fixed by opening a pr at https://github.com/lydell/js-tokens? |
nicolo-ribaudo
added
the
PR: Polish 💅
|
@nicolo-ribaudo No, js-tokens supports the latest ECMAScript standard on purpose. Besides, we already do special handling for JSX and brackets. |
nicolo-ribaudo
approved these changes
Oct 25, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pictures say more than a 1000 words, eh?
Before:
After:
(js-tokens considers
@and#to be invalid characters, because it only supports the latest stable specification, but in the Babel world they're not.)