Use peerDeps in register and babel-node, add missing peerDependencies, and declare devDependencies #6655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loganfsmyth
commented
Oct 31, 2017
loganfsmyth
commented
| Q | A |
|---|---|
| Fixed Issues? | |
| Patch: Bug Fix? | |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR | |
| Any Dependency Changes? |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5567/ |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5561/ |
hzoo
reviewed
Oct 31, 2017
| @@ -9,7 +9,7 @@ There are some shell-executable utility scripts, `babel-external-helpers.js` and | |||
| ## Install | |||
|
|
|||
| ```sh | |||
| npm install --save-dev @babel/cli | |||
| npm install --save-dev @babel/core @babel/cli | |||
There was a problem hiding this comment.
I guess we should remove babel-core in the deps for babel-cli too
There was a problem hiding this comment.
Woops, saw that it had the peerDep and didn't realize it still had it in dependencies.
hzoo
approved these changes
Oct 31, 2017
hzoo
added
the
PR: Internal 🏠
loganfsmyth
force-pushed
the
more-peerdeps
branch
from
ea7e643
to
2d7685b
Compare
|
cool, feel free to merge |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.