Allowed hintedNames for namespaced imports, changed some other defaul… #6744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts for more readable ones
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5665/ |
danez
approved these changes
Nov 5, 2017
Andarist
added
PR: Polish 💅
|
Yeah, sure - added New feature + Polish |
|
What if the import source looks like |
|
@danez valid identifiers are generated, i.e. var _fromPath = _interopRequireWildcard(require("../../from/path")) |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ts for more readable ones
Ive just wanted
addNamespaceto acceptshintedNameoption, but in the process I've noticed some auto-determined names make (imho) less sense that they could have, so I've tweaked those helpers a little bit.