Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move typscript test copy script to scripts folder and run once #6749

Merged
merged 1 commit into from
Nov 6, 2017

Conversation

danez
Copy link
Member

@danez danez commented Nov 5, 2017

Q                       A
Fixed Issues?
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

This removes the script from test/ as it is not really a test file and also fixes it to run with the new babylon location.

The script simply copies all relevant fixtures from babylon to babel-generator.

We should automate this somehow, but for now at least it works. Should we run this before running tests in make test? We could even create one fixture library that works for babel-generator and babylon for all features and not just typescript.

@danez danez added the PR: Internal 🏠 A type of pull request used for our changelog categories label Nov 5, 2017
@danez danez requested a review from a user November 5, 2017 17:23
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5672/

@existentialism existentialism merged commit 7dbed21 into master Nov 6, 2017
@hzoo hzoo deleted the typescript-copy-script branch November 9, 2017 23:24
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants