Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse async arrows with flow type parameters #6802

Merged
merged 3 commits into from
Nov 14, 2017
Merged

Parse async arrows with flow type parameters #6802

merged 3 commits into from
Nov 14, 2017

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Fixes #6712
Patch: Bug Fix? yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added area: flow pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Nov 12, 2017
@babel-bot
Copy link
Collaborator

babel-bot commented Nov 12, 2017 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5816/

Andarist
Andarist reviewed Nov 12, 2017
View reviewed changes
packages/babylon/src/plugins/flow.js Outdated
): ?N.ArrowFunctionExpression {
const node = this.startNodeAt(startPos, startLoc);

const oldInFunc = this.state.inFunction;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems really hacky, looks like the real problem is in the parseArrow or parseFunctionBodyAndFinish

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you are right.

nicolo-ribaudo
nicolo-ribaudo commented Nov 13, 2017
View reviewed changes
packages/babylon/test/fixtures/flow/type-generics/async-arrow-like/actual.js

// This looks A LOT like an async arrow function, but it isn't because
// T + U isn't a valid type parameter.
(async <T + U>(fn: T): T => fn);
Copy link
Member Author

@nicolo-ribaudo nicolo-ribaudo Nov 13, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I couldn't resist adding a really confusing test 😅

existentialism
existentialism approved these changes Nov 14, 2017
View reviewed changes
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicolo-ribaudo nicolo-ribaudo merged commit 9ae2363 into babel:master Nov 14, 2017
@nicolo-ribaudo nicolo-ribaudo deleted the async-arrow-type-parameters branch November 14, 2017 15:24
@jony89 jony89 mentioned this pull request Jan 9, 2018
Closed
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@Andarist Andarist Andarist approved these changes

Assignees
No one assigned
Labels
area: flow outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flow + async + generics => SyntaxError
4 participants
@nicolo-ribaudo @babel-bot @existentialism @Andarist