Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[preset-env] Exclude transform-typeof-symbol with `loose` option. #6831

Merged
merged 3 commits into from Nov 15, 2017

Conversation

@yavorsky
Copy link
Member

@yavorsky yavorsky commented Nov 15, 2017

Q                       A
Fixed Issues? Fixes #6822
Major: Breaking Change? 👍
Tests Added + Pass? Yes
License MIT

Like @hzoo mentioned in #6822, we have enough reasons to do so, and this will simplify configs for many projects. I have found several examples, where people mix exclude: ['transform-runtime'] and loose: true options:

@hzoo
Copy link
Member

@hzoo hzoo commented Nov 15, 2017

You mean loose in the title 😛?

@yavorsky
Copy link
Member Author

@yavorsky yavorsky commented Nov 15, 2017

You mean loose in the title 😛?

Omg, I need to sleep 😰

@yavorsky yavorsky changed the title [preset-env] Exclude transform-typeof-symbol with `spec` option. [preset-env] Exclude transform-typeof-symbol with `loose` option. Nov 15, 2017
@@ -111,12 +111,25 @@ const getPlatformSpecificDefaultFor = (targets: Targets): ?Array<string> => {
return isAnyTarget || isWebTarget ? defaultWebIncludes : null;
};

const getOptionSpecificExcludesFor = ({

This comment has been minimized.

@existentialism

existentialism Nov 15, 2017
Member

Should we move this into ./default-includes.js and maybe rename it defaults.js?

Another option it to just move filterItems (since its pretty self contained) alongside both of them?

Not critical, there's just so much going on in index.

EDIT: let's do this in a followup, if anything.

@existentialism existentialism merged commit de35979 into master Nov 15, 2017
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87.25% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@existentialism existentialism deleted the typeof-symbol-loose branch Nov 15, 2017
@existentialism existentialism mentioned this pull request Dec 1, 2017
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.