[preset-env] Exclude transform-typeof-symbol with loose option.
#6831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
approved these changes
Nov 15, 2017
|
You mean loose in the title 😛? |
Omg, I need to sleep 😰 |
yavorsky
changed the title
spec option.loose option.
| @@ -111,12 +111,25 @@ const getPlatformSpecificDefaultFor = (targets: Targets): ?Array<string> => { | |||
| return isAnyTarget || isWebTarget ? defaultWebIncludes : null; | |||
| }; | |||
|
|
|||
| const getOptionSpecificExcludesFor = ({ | |||
There was a problem hiding this comment.
Should we move this into ./default-includes.js and maybe rename it defaults.js?
Another option it to just move filterItems (since its pretty self contained) alongside both of them?
Not critical, there's just so much going on in index.
EDIT: let's do this in a followup, if anything.
existentialism
added
pkg: preset-env
PR: Breaking Change 💥
Merged
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like @hzoo mentioned in #6822, we have enough reasons to do so, and this will simplify configs for many projects. I have found several examples, where people mix
exclude: ['transform-runtime']andloose: trueoptions: