Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Use HTTPS and relative links when possible #6843

Merged
merged 1 commit into from
Nov 17, 2017
Merged

README: Use HTTPS and relative links when possible #6843

merged 1 commit into from
Nov 17, 2017

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Nov 17, 2017

Q                       A
Fixed Issues? N/A
Patch: Bug Fix? 👎
Major: Breaking Change? 👎
Minor: New Feature? 👎
Tests Added + Pass? N/A
Documentation PR 👍
Any Dependency Changes? 👎
License MIT

Just making links a bit cleaner.

@babel-bot
Copy link
Collaborator

babel-bot commented Nov 17, 2017

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5887/

Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@hzoo
Copy link
Member

hzoo commented Nov 17, 2017

The reason we weren't using relative links is probably since for the other repos we copy them to the website so the urls wouldn't work (on babeljs.io)

It's fine for this since I don't think this is used anywhere else though

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool and previously we didn't have https so I guess it never got changed! 👍

@hzoo hzoo merged commit e67cfc5 into babel:master Nov 17, 2017
@hzoo hzoo added the PR: Docs 📝 A type of pull request used for our changelog categories label Nov 17, 2017
@kevinji kevinji deleted the patch-1 branch November 17, 2017 19:19
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants