Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .github and .idea to .npmignore #6866

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Add .github and .idea to .npmignore #6866

merged 1 commit into from
Nov 21, 2017

Conversation

aaharu
Copy link
Contributor

@aaharu aaharu commented Nov 21, 2017 •
edited
Loading

Q                       A
Fixed Issues? no
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Tests Added + Pass? Yes
Documentation PR no
Any Dependency Changes? no
License MIT

babel-preset-env@1.6.1 includes unnecessary files.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5938/

1 similar comment
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5938/

@yavorsky
Copy link
Member

I think we should unify npmignore in the future and use editor stuff like .vscode, .idea for all packages.

@yavorsky yavorsky merged commit d72d567 into babel:master Nov 21, 2017
@Andarist
Copy link
Member

Imho having files in package.json is way more maintainable, maybe we could switch to using it instead?

@existentialism existentialism added the PR: Internal 🏠 A type of pull request used for our changelog categories label Nov 22, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xtuc xtuc xtuc approved these changes

@yavorsky yavorsky yavorsky approved these changes

@Andarist Andarist Andarist approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aaharu @babel-bot @yavorsky @Andarist @xtuc @existentialism