Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update regenerator (removed explicit babel-types dep) #6917

Merged
merged 1 commit into from
Nov 27, 2017
Merged

update regenerator (removed explicit babel-types dep) #6917

merged 1 commit into from
Nov 27, 2017

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Nov 27, 2017 •
edited
Loading

Q                       A
Fixed Issues? Fixes #6908, Fixes #6262 (any others?)
Patch: Bug Fix? Yes

Should also remove the extra babel-types in standalone

@hzoo hzoo requested a review from benjamn November 27, 2017 16:12
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6013/

@existentialism existentialism added PR: Dependency ⬆️ PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Nov 27, 2017
nicolo-ribaudo
nicolo-ribaudo approved these changes Nov 27, 2017
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also remove the extra babel-types in standalone

2373 kB instead of 2515 kB (6% less)

@Andarist Andarist merged commit 58962c3 into master Nov 27, 2017
@Andarist Andarist deleted the hzoo-patch-1 branch November 27, 2017 22:16
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@Andarist Andarist Andarist approved these changes

@benjamn benjamn Awaiting requested review from benjamn

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories PR: Dependency ⬆️
Projects
None yet
Milestone
No milestone
5 participants
@hzoo @babel-bot @existentialism @nicolo-ribaudo @Andarist