UpdateExpressions as callees must be parenthesized #6922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
pkg: generator
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6019/ |
existentialism
approved these changes
Nov 27, 2017
Andarist
reviewed
Nov 27, 2017
| return ( | ||
| (t.isMemberExpression(parent) && parent.object === node) || | ||
| // (foo++).test(), (foo++)[0] |
There was a problem hiding this comment.
out of curiosity, how to produce a code which spits out an object when postfix operator is used?
There was a problem hiding this comment.
I just tried using a combination of proxies and with, but I don't think it is possible.
Anyway, someone might do something like
var i = 1;
var x = (i++).toString();
Andarist
approved these changes
Nov 27, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples:
I found this bug because I actually wrote something like
(x++)(function() {})()because I forgot a semicolon lol