Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat import type * as a parser error #7061

Merged
merged 1 commit into from Dec 19, 2017
Merged

Conversation

existentialism
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix? y
Major: Breaking Change? maybe?
Minor: New Feature? n
Tests Added + Pass? y/y
Documentation PR
Any Dependency Changes?
License MIT

Makes import type * return a parser error (note typeof does not).

Also reorganized/merged some of the unnamed numbered tests in type-annotations into type-imports.

Matches behavior in flow: facebook/flow@71e2774

@existentialism existentialism added area: flow pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Dec 19, 2017
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6243/

@hzoo hzoo merged commit 2b06535 into master Dec 19, 2017
@existentialism existentialism deleted the import-type-namespace-error branch December 19, 2017 15:57
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: flow outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants