Support parsing export default abstract class {}
#7075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6276/ |
existentialism
added
area: typescript
pkg: parser
PR: Bug Fix 🐛
There was a problem hiding this comment.
LGTM.
If the comment I wrote makes make flow report errors, just leave it as is.
I edited Fixes #7060 -> Fixes (partially) #7060 in the pr description to prevent GitHub from closing that issue when this PR is merged, since @dec abstract class still doesn't work.
| @@ -1373,6 +1354,27 @@ export default class StatementParser extends ExpressionParser { | |||
| return this.finishNode(node, "ExportNamedDeclaration"); | |||
| } | |||
|
|
|||
| parseExportDefaultExpression(): N.Expression { | |||
There was a problem hiding this comment.
This return type should be N.Expression | N.Declaration
existentialism
approved these changes
Dec 21, 2017
ghost
deleted the
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports parsing a class expression in
export defaultthat starts with theabstractkeyword.This does not allow parsing
abstract classas an expression in general, because TypeScript only allows those in declaration positions (and treatsexport default abstract classas a declaration).