Update README.md #7140
Merged
Update README.md #7140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version of the api allowed passing ignore options as a function, which now can only be an array of regex / functions. The current docs are somewhat ambiguous with regards to this breaking change. Anyway I did some editing, let me know if this is ok with you guys.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6421/ |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6399/ |
Qantas94Heavy
added
the
PR: Docs 📝
packages/babel-register/README.md
Outdated
| if (filename === "/path/to/es6-file.js") { | ||
| return false; | ||
| } else { | ||
| // Optional ignore array |
There was a problem hiding this comment.
Maybe you could add something to make it clear that the file will be ignored if it matches any of the ignore entries?
[skip-ci]
eladchen
commented
Jan 1, 2018
existentialism
requested changes
Jan 3, 2018
packages/babel-register/README.md
Outdated
| } else { | ||
| // Array of ignore conditions ( Optional ) | ||
| // A condition can be either a regex, or a function. | ||
| // When a file path **matchs** this regex then then it is **not** compiled. |
There was a problem hiding this comment.
// When a file path matches this regex then it is not compiled.
packages/babel-register/README.md
Outdated
| if (filename === "/path/to/es6-file.js") { | ||
| return false; | ||
| } else { | ||
| // Array of ignore conditions ( Optional ) |
There was a problem hiding this comment.
Nit remove spaces surrounding Optional
packages/babel-register/README.md
Outdated
| return true; | ||
| } | ||
| }], | ||
| } |
|
@eladchen thanks for the PR! |
|
@existentialism My pleasure. |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of the api allowed passing ignore option as a function, which now can only be an array of regex / functions.
The current docs are somewhat ambiguous with regards to this breaking change.
Anyway I did some editing, let me know if this is ok with you guys.
[skip ci]