Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process .babelignore before .babelrc #7161

Merged
merged 1 commit into from
Jan 6, 2018
Merged

Process .babelignore before .babelrc #7161

merged 1 commit into from
Jan 6, 2018

Conversation

loganfsmyth
Copy link
Member

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

This was a regression from de63443 which is causing the failures in #7104, sorry!

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6475/

@babel babel deleted a comment from babel-bot Jan 5, 2018
@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jan 5, 2018
hzoo
hzoo approved these changes Jan 5, 2018
View reviewed changes
Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh great, and an ordering test would be good to later?

@loganfsmyth loganfsmyth merged commit bb17b72 into babel:master Jan 6, 2018
@loganfsmyth loganfsmyth deleted the ignore-regression branch January 6, 2018 04:39
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hzoo hzoo hzoo approved these changes

@yavorsky yavorsky yavorsky approved these changes

@Andarist Andarist Andarist approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@loganfsmyth @babel-bot @hzoo @yavorsky @Andarist