Tweak and add tests to babel-helper-annotate-as-pure #7245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existentialism
added
the
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6670/ |
nicolo-ribaudo
approved these changes
Jan 20, 2018
|
(We need a |
|
Still a bug fix so it's ok - I just use "internal for tests", (open to suggestions to change though) |
Andarist
reviewed
Jan 20, 2018
| return leadingComments.some(comment => /[@#]__PURE__/.test(comment.value)); | ||
| }; | ||
| const isPureAnnotated = ({ leadingComments }) => | ||
| leadingComments && |
There was a problem hiding this comment.
@existentialism we should always return boolean from this
There was a problem hiding this comment.
@Andarist good point, ill fix
aminmarashi
pushed a commit
to aminmarashi/babel
that referenced
this pull request
Mar 17, 2018
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to clear through a big backlog of PRs I've been too busy to get done :(
This was originally part of a larger PR that normalizes comment props on nodes, but figured we could land this while bikeshedding that.