-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add core-js as valid polyfill source #7315
Conversation
It was confusing on npm 2 (babel-polyfill -> core-js import) so we did this whole thing about creating these stub files but it was too unwieldy and it sucked on our end to maintain it. Yeah we reverted that so this is ok now. And also in addition we wanted to either kill babel-polyfill entirely given it's literally 2 imports and/or allow preset-env to map against any polyfill you want |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6808/ |
This reverts commit 593c1a0.
@kaicataldo Why this has been reverted? Actually not on master. |
@xtuc I think I've seen a comment that this was a mistake and the intention was to delete the branch |
Uhhh, I have no idea. I accidentally clicked the revert button on this PR last night while trying to delete my branch, but I've never looked at this PR before... |
I brought that up a while ago, but wanted to finally start the discussion. I'm not sure why it was removed in v7.x. I found it very useful to be able to use
import "core-js"
with babel-preset-env builtIn option. Especially to mitigate the problem that the wrong version of core-js could be installed on toplevel, so that the generated imports from core-js do fail.Would also be interested why it was removed?