Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core-js as valid polyfill source #7315

Merged
merged 1 commit into from
Feb 4, 2018
Merged

Conversation

danez
Copy link
Member

@danez danez commented Feb 2, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix? ?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

I brought that up a while ago, but wanted to finally start the discussion. I'm not sure why it was removed in v7.x. I found it very useful to be able to use import "core-js" with babel-preset-env builtIn option. Especially to mitigate the problem that the wrong version of core-js could be installed on toplevel, so that the generated imports from core-js do fail.

Would also be interested why it was removed?

@hzoo
Copy link
Member

hzoo commented Feb 2, 2018

It was confusing on npm 2 (babel-polyfill -> core-js import) so we did this whole thing about creating these stub files but it was too unwieldy and it sucked on our end to maintain it. Yeah we reverted that so this is ok now. And also in addition we wanted to either kill babel-polyfill entirely given it's literally 2 imports and/or allow preset-env to map against any polyfill you want

@danez danez added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Feb 4, 2018
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6808/

@existentialism existentialism merged commit 593c1a0 into master Feb 4, 2018
@existentialism existentialism deleted the danez-patch-1 branch February 4, 2018 23:53
kaicataldo added a commit that referenced this pull request Feb 5, 2018
@xtuc
Copy link
Member

xtuc commented Feb 5, 2018

@kaicataldo Why this has been reverted? Actually not on master.

@Andarist
Copy link
Member

Andarist commented Feb 5, 2018

@xtuc I think I've seen a comment that this was a mistake and the intention was to delete the branch

@kaicataldo
Copy link
Member

Uhhh, I have no idea. I accidentally clicked the revert button on this PR last night while trying to delete my branch, but I've never looked at this PR before...

aminmarashi pushed a commit to aminmarashi/babel that referenced this pull request Mar 17, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants