Solves Tagged template literal size optimization #7379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
debugpai
commented
Feb 14, 2018
•
debugpai
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #7352 |
| Tests Added + Pass? | Yes |
| Any Dependency Changes? | no |
| License | MIT |
- Adds a check to see if strings and raw strings are equal
- If they are equal doesn't pass raws to call expression
- Modifies taggedTemplateHelpers to slice strings if raws is not passed
debugpai
force-pushed
the
tagged-template-literal
branch
from
4a316c3
to
349a2cf
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6887/ |
jridgewell
requested changes
Feb 14, 2018
| [ | ||
| t.arrayExpression(strings), | ||
| !isStringsRawEqual ? t.arrayExpression(raws) : null, | ||
| ].filter(x => x), |
There was a problem hiding this comment.
Let’s hoist out the array and push raws in inside an if-statement.
| @@ -0,0 +1 @@ | |||
| var foo = tag`wow`; | |||
There was a problem hiding this comment.
Let’s add a multi quasi case:
var bar = tag`first${1}second`;
existentialism
added
the
PR: Polish 💅
jridgewell
approved these changes
Feb 14, 2018
aminmarashi
pushed a commit
to aminmarashi/babel
that referenced
this pull request
Mar 17, 2018
* Tagged template literal size optimization solves babel#7352 * Incorporates review changes
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.