Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec Violation: Fix var initializer in for-in loop #7392

Merged
merged 1 commit into from
Mar 5, 2018
Merged

Spec Violation: Fix var initializer in for-in loop #7392

merged 1 commit into from
Mar 5, 2018

Conversation

ksashikumar
Copy link
Contributor

Q                       A
Fixed Issues? #6699
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 18, 2018 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6908/

@loganfsmyth loganfsmyth added PR: Spec Compliance 👓 A type of pull request used for our changelog categories PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Mar 5, 2018
@loganfsmyth loganfsmyth merged commit d187c26 into babel:master Mar 5, 2018
@loganfsmyth
Copy link
Member

Thanks!

@loganfsmyth loganfsmyth mentioned this pull request Mar 5, 2018
Closed
@ksashikumar ksashikumar deleted the for_in_initializer_bug branch March 5, 2018 05:00
@existentialism
Copy link
Member

@ksashikumar not sure if you want to take a look, but there's also:

annexB/language/statements/for-in/bare-initializer.js

@ksashikumar
Copy link
Contributor Author

@existentialism Oops! Will look into it! 👍

This was referenced Mar 14, 2018
Closed
Closed
Closed
Merged
Merged
Closed
aminmarashi pushed a commit to aminmarashi/babel that referenced this pull request Mar 17, 2018
@ksashikumar @aminmarashi
Spec Violation: Fix var initializer in for-in loop (babel#7392)
20bae35
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories PR: Spec Compliance 👓 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ksashikumar @babel-bot @loganfsmyth @existentialism