Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing promise polyfill deps for preset-env's useBuiltIns: usage #7400

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Add missing promise polyfill deps for preset-env's useBuiltIns: usage #7400

merged 1 commit into from
Feb 23, 2018

Conversation

existentialism
Copy link
Member

Q                       A
Fixed Issues? Fixes #7395
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: preset-env labels Feb 20, 2018
@babel-bot
Copy link
Collaborator

babel-bot commented Feb 20, 2018 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6926/

zloirock
zloirock requested changes Feb 20, 2018
View reviewed changes
Copy link
Member

@zloirock zloirock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same should be added at least also for Promise.race.

@zloirock
Copy link
Member

zloirock commented Feb 20, 2018 •
edited
Loading

Also, we could have the same problem for collections constructors - they also use iterators when having arguments. Array iterator is not the only dependency of Promise, see this entry point (es6.array.iterator added implicitly in web.dom.iterable).

@existentialism
Copy link
Member Author

@zloirock Thanks, great catch! It's probably better for us to just add es6.object.to-string, es6.string.iterator and web.dom.iterable to Promise built in definition instead?

@zloirock
Copy link
Member

@existentialism es6.object.to-string to Promise built in definition, es6.string.iterator and web.dom.iterable to Promise.all and Promise.race - we need it only for those methods.

@existentialism
Copy link
Member Author

existentialism commented Feb 21, 2018 •
edited
Loading

@zloirock updated! thanks again for the help

@existentialism existentialism changed the title Add array.iterator with Promise.all in preset-env's useBuiltIns: usage @existentialism Add missing promise polyfill deps for preset-env's useBuiltIns: usage Feb 21, 2018
@existentialism existentialism changed the title @existentialism Add missing promise polyfill deps for preset-env's useBuiltIns: usage Add missing promise polyfill deps for preset-env's useBuiltIns: usage Feb 21, 2018
@existentialism existentialism merged commit 182fe7b into master Feb 23, 2018
@existentialism existentialism deleted the issue7395 branch February 23, 2018 14:45
This was referenced Mar 14, 2018
Closed
Closed
Closed
Merged
Merged
Closed
aminmarashi pushed a commit to aminmarashi/babel that referenced this pull request Mar 17, 2018
@existentialism @aminmarashi
Add missing promise polyfill deps for preset-env's useBuiltIns: usage (…
daa435a 
…babel#7400)
@LinusBorg LinusBorg mentioned this pull request Jun 25, 2018
Closed
@VIGDXX VIGDXX mentioned this pull request Jun 28, 2019
Closed
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zloirock zloirock zloirock approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature detection error in babel-preset-env and IE11
3 participants
@existentialism @babel-bot @zloirock