Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install peerDependencies and remove unused async dependency #7453

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Conversation

danez
Copy link
Member

@danez danez commented Feb 28, 2018

Q                       A
Fixed Issues? n
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? y
Documentation PR
Any Dependency Changes?
License MIT

Fixes some peer dependency warnings on install.
Removes async, I couldn't find any usages in our code

@danez danez added the PR: Internal 🏠 A type of pull request used for our changelog categories label Feb 28, 2018
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7000/

@hzoo
Copy link
Member

hzoo commented Feb 28, 2018

I guess if it passes ok!

@hzoo hzoo merged commit 1a454f6 into master Feb 28, 2018
@danez danez deleted the deps branch February 28, 2018 16:00
aminmarashi pushed a commit to aminmarashi/babel that referenced this pull request Mar 17, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants