Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require tests to use input.mjs for modules, and output.js/.mjs based on active transforms #7484

Merged
merged 3 commits into from Mar 4, 2018

Conversation

@loganfsmyth
Copy link
Member

loganfsmyth commented Mar 4, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix? N
Major: Breaking Change? N
Minor: New Feature? Y (barely, result.sourceType)
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

Give meaning to test fixture input and output file extensions so that we can validate that transforms actually manipulate the sourceType properly.

  • To parse input as sourceType: 'module' the name must be input.mjs
  • Output will be .js or .mjs based on if the sourceType was changed.
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Mar 4, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7078/


if (expected.loc !== expectedFile) {
try {
fs.unlinkSync(expected.loc);

This comment has been minimized.

Copy link
@nicolo-ribaudo

nicolo-ribaudo Mar 4, 2018

Member

I don't understand when this code is executed. If !expected.code (line 394), shouldn't output.m?js not exist?

This comment has been minimized.

Copy link
@loganfsmyth

loganfsmyth Mar 4, 2018

Author Member

It's not super likely, so that's a fair question. Technically the file could have been emptied instead of deleted, so I figured it wouldn't hurt to add some logic to try to avoid creating sibling files.

@danez
danez approved these changes Mar 4, 2018
@loganfsmyth loganfsmyth force-pushed the loganfsmyth:test-input-mjs branch from bb4e5fa to 7cc00cc Mar 4, 2018
@loganfsmyth loganfsmyth merged commit 7f8f4e8 into babel:master Mar 4, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 84.52% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@loganfsmyth loganfsmyth deleted the loganfsmyth:test-input-mjs branch Mar 4, 2018
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.