Require tests to use input.mjs for modules, and output.js/.mjs based on active transforms #7484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7078/ |
loganfsmyth
added
the
PR: Internal 🏠
|
|
||
| if (expected.loc !== expectedFile) { | ||
| try { | ||
| fs.unlinkSync(expected.loc); |
There was a problem hiding this comment.
I don't understand when this code is executed. If !expected.code (line 394), shouldn't output.m?js not exist?
There was a problem hiding this comment.
It's not super likely, so that's a fair question. Technically the file could have been emptied instead of deleted, so I figured it wouldn't hurt to add some logic to try to avoid creating sibling files.
nicolo-ribaudo
approved these changes
Mar 4, 2018
danez
approved these changes
Mar 4, 2018
loganfsmyth
force-pushed
the
test-input-mjs
branch
from
bb4e5fa
to
7cc00cc
Compare
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
result.sourceType)Give meaning to test fixture input and output file extensions so that we can validate that transforms actually manipulate the
sourceTypeproperly.sourceType: 'module'the name must beinput.mjs.jsor.mjsbased on if the sourceType was changed.