Enable and fix babel-register tests #7487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7076/ |
danez
added
the
PR: Internal 🏠
existentialism
approved these changes
Mar 5, 2018
| describe("cache", () => { | ||
| let load, get, save; | ||
|
|
||
| beforeEach(() => { | ||
| // Since lib/cache is a singleton we need to fully reload it | ||
| delete require.cache[require.resolve("../lib/cache")]; | ||
| jest.resetModuleRegistry(); |
There was a problem hiding this comment.
Isn't this run automatically by jest before each test? (jestjs/jest#587 (comment))
There was a problem hiding this comment.
Maybe it changed? Or it is only run once for each test file? At least the tests weren't working without.
There was a problem hiding this comment.
Should be jest.resetModules(). resetModuleRegistry is a deprecated alias and not publicly documented.
It is not run automatically between tests in a single suite, but each suite (file) is run in isolation
There was a problem hiding this comment.
Ah thanks, I somewhere found it documented, but now I can't find it anymore :) Will fix it.
nicolo-ribaudo
approved these changes
Mar 5, 2018
aminmarashi
pushed a commit
to aminmarashi/babel
that referenced
this pull request
Mar 17, 2018
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the base register test to mock
pirates and source-map supportand just test it calls these libs correctly.The cache tests worked after fixing the cache invalidation with jest.