Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a more useful diff when comparing fixture files. #7520

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Show a more useful diff when comparing fixture files. #7520

merged 1 commit into from
Mar 7, 2018

Conversation

loganfsmyth
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

Outputs the filename so it is easy to grab it and delete the file.

@loganfsmyth loganfsmyth added the PR: Internal 🏠 A type of pull request used for our changelog categories label Mar 7, 2018
@loganfsmyth loganfsmyth requested a review from danez March 7, 2018 20:10
@babel-bot
Copy link
Collaborator

babel-bot commented Mar 7, 2018 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7143/

hzoo
hzoo approved these changes Mar 7, 2018
View reviewed changes
Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Would be nice to add a command to delete for you as well

@loganfsmyth loganfsmyth merged commit 53825f8 into babel:master Mar 7, 2018
@loganfsmyth loganfsmyth deleted the better-jest-file-diff branch March 7, 2018 20:27
@nicolo-ribaudo
Copy link
Member

❤️

aminmarashi pushed a commit to aminmarashi/babel that referenced this pull request Mar 17, 2018
@loganfsmyth @aminmarashi
Show a more useful diff when comparing fixture files. (babel#7520)
1ffd8ac
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danez danez danez approved these changes

@hzoo hzoo hzoo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@loganfsmyth @babel-bot @nicolo-ribaudo @danez @hzoo