Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lodash/map with array equivalent #7550

Merged
merged 2 commits into from Mar 12, 2018
Merged

Replace lodash/map with array equivalent #7550

merged 2 commits into from Mar 12, 2018

Conversation

@danez
Copy link
Member

danez commented Mar 11, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes? n
License MIT

I#m working on improving babel-standalone and noticed that this is totally unnecessary as arr.map() should be supported everywhere.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Mar 11, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7208/

@@ -220,7 +219,7 @@ export const list = {
*/

VariableDeclaration(node: Object): Array<Object> {
return map(node.declarations, "init");
return node.declarations ? node.declarations.map(decl => decl.init) : [];

This comment has been minimized.

Copy link
@wtgtybhertgeghgtwtg

wtgtybhertgeghgtwtg Mar 12, 2018

Contributor

Is declarations nullable?

@danez

This comment has been minimized.

Copy link
Member Author

danez commented Mar 12, 2018

Looking at other parts of the code we already used node.declarations without checking null, so it probably isn't. Also codecoverage says that the else branch here is never triggered. I change it.

@xtuc
xtuc approved these changes Mar 12, 2018
@danez danez merged commit 9d2d499 into master Mar 12, 2018
5 checks passed
5 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 84.59% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@danez danez deleted the lodash-map-remove branch Mar 12, 2018
This was referenced Mar 15, 2018
aminmarashi-binary added a commit to aminmarashi-binary/babel that referenced this pull request Mar 17, 2018
* Replace lodash/map with array equivalent

* Fix review comments
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants
You can’t perform that action at this time.