Replace lodash/map with array equivalent #7550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
added
the
PR: Polish 💅
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7208/ |
nicolo-ribaudo
approved these changes
Mar 11, 2018
yavorsky
approved these changes
Mar 11, 2018
| @@ -220,7 +219,7 @@ export const list = { | |||
| */ | |||
|
|
|||
| VariableDeclaration(node: Object): Array<Object> { | |||
| return map(node.declarations, "init"); | |||
| return node.declarations ? node.declarations.map(decl => decl.init) : []; | |||
There was a problem hiding this comment.
Is declarations nullable?
|
Looking at other parts of the code we already used node.declarations without checking null, so it probably isn't. Also codecoverage says that the else branch here is never triggered. I change it. |
xtuc
approved these changes
Mar 12, 2018
This was referenced Mar 15, 2018
Closed
aminmarashi
pushed a commit
to aminmarashi/babel
that referenced
this pull request
Mar 17, 2018
* Replace lodash/map with array equivalent * Fix review comments
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I#m working on improving babel-standalone and noticed that this is totally unnecessary as
arr.map()should be supported everywhere.