Disable flow on transformClass, fix preset-env errors #7605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7344/ |
existentialism
approved these changes
Mar 20, 2018
existentialism
added
the
PR: Internal 🏠
loganfsmyth
reviewed
Mar 20, 2018
| Array.from(validIncludesAndExcludes).filter( | ||
| item => regexp instanceof RegExp && regexp.test(item), | ||
| ); | ||
|
|
||
| const flatten = array => [].concat(...array); | ||
|
|
||
| const expandIncludesAndExcludes = ( | ||
| plugins: Array<string | RegExp> = [], | ||
| plugins: Array<string> = [], |
There was a problem hiding this comment.
@existentialism Is this right? I thought we supported regexes now?
thymikee
commented
Mar 20, 2018
| @@ -35,7 +35,7 @@ const expandIncludesAndExcludes = ( | |||
| plugins: Array<string | RegExp> = [], | |||
| type: string, | |||
| ): Array<string> => { | |||
| if (plugins.length === 0) return plugins; | |||
| if (plugins.length === 0) return []; | |||
There was a problem hiding this comment.
Couldn't return plugins here because the output is different type than the input. I assumed that we're safe to return just an empty array here, because technically we don't accept any other types.
xtuc
approved these changes
Mar 20, 2018
mAAdhaTTah
added a commit
to valtech-nyc/babel
that referenced
this pull request
Mar 21, 2018
* master: (140 commits) Update to beta.42 (babel#7609) Disable flow on transformClass, fix preset-env errors (babel#7605) Logical Assignment: ensure computed key isn't recomputed (babel#7604) Remove obsolete max-len eslint rule and reformat some stuff to fit (babel#7602) Centralize Babel's own compilation config to make it easier to follow. (babel#7599) Run prettier to format all JSON. Tweak es2015-related plugin order in preset-env (babel#7586) Refactored quirky inheritance in babel-plugin-transform-classes (babel#7444) Add RegExp support to include/exclude preset-env options (babel#7242) v7.0.0-beta.42 Use strict namespace behavior for mjs files. (babel#7545) Remove outdated spec deviation note [skip ci] (babel#7571) Ensure that the backward-compat logic for plugin-utils copies over the version API properly. (babel#7580) Rename actual/expected test files to input/output (babel#7578) Use helper-module-import inside entry plugin too Use helper-module-imports instead of custom import (babel#7457) Fix "Module build failed: Error: Cannot find module '@babel/types'" (babel#7575) Wrap wrapNativeSuper helpers in redefining functions for better tree-shakeability (babel#7188) Favour extends helper over objectWithoutProperties when whole object gets copied anyway (babel#7390) Fix incorrect value of _cache in _wrapNativeSuper (babel#7570) ...
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled Flow from
transformClass.js(see #7444) which caused a cascade of errors, as per @loganfsmyth request. Also fixed small Flow issues I found in other files so nowyarn flowpass.