Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to overwrite failing output fixtures #7679

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Add option to overwrite failing output fixtures #7679

merged 1 commit into from
Apr 6, 2018

Conversation

jridgewell
Copy link
Member

/cc @zloirock

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7485/

@nicolo-ribaudo
Copy link
Member

I think that we could use jest snapshots?

@jridgewell
Copy link
Member Author

I know nothing about jest.

nicolo-ribaudo
nicolo-ribaudo approved these changes Apr 6, 2018
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at jest's documentation and it would put all the outputs in the same file, so it wouldn't work for us.

@existentialism existentialism added PR: Internal 🏠 A type of pull request used for our changelog categories PR: New Feature 🚀 A type of pull request used for our changelog categories and removed PR: Internal 🏠 A type of pull request used for our changelog categories labels Apr 6, 2018
@existentialism existentialism merged commit 3f72f1d into babel:master Apr 6, 2018
@jridgewell jridgewell deleted the test-runner-overwrite branch April 6, 2018 17:38
@jridgewell jridgewell restored the test-runner-overwrite branch April 9, 2018 17:23
@hzoo
Copy link
Member

hzoo commented Apr 21, 2018

Let's add this to CONTRIBUTING.md too (I'll just do it now)

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jridgewell @babel-bot @nicolo-ribaudo @hzoo @existentialism