Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup object super traversal #7681

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Cleanup object super traversal #7681

merged 1 commit into from
Apr 6, 2018

Conversation

jridgewell
Copy link
Member

n2 traversals are bad.

@jridgewell jridgewell added the PR: Polish 💅 A type of pull request used for our changelog categories label Apr 6, 2018
@babel-bot
Copy link
Collaborator

babel-bot commented Apr 6, 2018 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7490/

nicolo-ribaudo
nicolo-ribaudo approved these changes Apr 6, 2018
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also found #7682 which is related to this code.

existentialism
existentialism approved these changes Apr 6, 2018
View reviewed changes
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jridgewell jridgewell merged commit 637bfe7 into babel:master Apr 6, 2018
@jridgewell jridgewell deleted the object-super branch April 6, 2018 19:40
@jridgewell jridgewell restored the object-super branch April 9, 2018 17:23
@jridgewell jridgewell mentioned this pull request Apr 19, 2018
Closed
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jridgewell @babel-bot @existentialism @nicolo-ribaudo