Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tagged template literal global caching #7722

Merged
merged 3 commits into from
Apr 13, 2018
Merged

Remove tagged template literal global caching #7722

merged 3 commits into from
Apr 13, 2018

Conversation

jridgewell
Copy link
Member

Fixes #7350.

@jridgewell jridgewell added PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Template Literal Revision labels Apr 13, 2018
@babel-bot
Copy link
Collaborator

babel-bot commented Apr 13, 2018 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7589/

xtuc
xtuc approved these changes Apr 13, 2018
View reviewed changes
packages/babel-plugin-transform-template-literals/test/fixtures/default/cache-revision/input.js Outdated
}
assert.equal(foo(), foo());
assert.equal(bar(), bar());
assert.notEqual(foo(), bar());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please test the output? A bug could cause assert.equal(0, 0); for ex.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

nicolo-ribaudo
nicolo-ribaudo requested changes Apr 13, 2018
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use expect(actual).[not].toBe(expected) instead of assert?

nicolo-ribaudo
nicolo-ribaudo reviewed Apr 13, 2018
View reviewed changes
packages/babel-plugin-transform-template-literals/src/index.js Outdated
if (!isStringsRawEqual) {
callExpressionInput.push(t.arrayExpression(raws));
}
const programPath = path.find(p => p.isProgram());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use path.scope.getProgramParent()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

xtuc
xtuc approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update

@loganfsmyth loganfsmyth mentioned this pull request Apr 13, 2018
Closed
@jridgewell jridgewell merged commit 29eafbb into babel:master Apr 13, 2018
@jridgewell jridgewell deleted the tagged-template-literal-cache branch April 13, 2018 15:51
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xtuc xtuc xtuc approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Template Literal Revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spec change: Tagged template literals are no longer cached globally
4 participants
@jridgewell @babel-bot @xtuc @nicolo-ribaudo