Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix await in function name and parameters #7727

Merged
merged 3 commits into from Nov 6, 2018

Conversation

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Apr 13, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix? y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT
@@ -525,10 +525,15 @@ export default class ExpressionParser extends LValParser {
}
return this.finishNode(node, "MemberExpression");
} else if (!noCalls && this.match(tt.parenL)) {
const oldMaybeInArrowParameters = this.state.maybeInArrowParameters;
const oldYOAIPAP = this.state.yieldOrAwaitInPossibleArrowParameters;

This comment has been minimized.

Copy link
@nicolo-ribaudo

nicolo-ribaudo Apr 13, 2018

Author Member

Any sugestion for a shorter name than yieldOrAwaitInPossibleArrowParameters? 😆

This comment has been minimized.

Copy link
@existentialism

existentialism May 15, 2018

Member

None other than Parameters -> Params, but not a huge difference lol

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Apr 13, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9338/

@@ -12,6 +12,7 @@ ES6/binding-pattern/object-pattern/await-prop-in-async-function.js
JSX_invalid/migrated_0000.js
arrow_function_invalid/migrated_0002.js
async_await/async_generic_method.js
async_await/migrated_0007.js
@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo:await-in-params branch from c2ee6bc to bdf4159 May 14, 2018
@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo:await-in-params branch from bdf4159 to 3e1fad3 Nov 5, 2018
@nicolo-ribaudo nicolo-ribaudo requested a review from danez Nov 5, 2018
@danez
danez approved these changes Nov 6, 2018
Copy link
Member

danez left a comment

Looks good to me. No idea for a way shorter name though.

For reference here are the fixes that acorn did to fix nearly the same things:
acornjs/acorn@7163d84
acornjs/acorn@5ab3d01

@nicolo-ribaudo nicolo-ribaudo merged commit 2fa1984 into babel:master Nov 6, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.6% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:await-in-params branch Nov 6, 2018
@danez

This comment has been minimized.

Copy link
Member

danez commented Dec 3, 2018

FYI: The tests of this PR were put into packages/babylon/tests/..., they are now moved to babel-parser in fa9df67 and run correctly :)

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented Dec 3, 2018

Thank you!

@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.