Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move subclass inheritance to end #7772

Merged

Conversation

@jridgewell
Copy link
Member

jridgewell commented Apr 21, 2018

We were using Object.create to setup the prototype chain at the start of the class definition, which lead to #7771.

I was a bit worried about a speed hit, but it seems everyone optimizes the two patterns the same way.
https://jsbench.github.io/#f9fca52407643d96458a35763b201215

Fixes #7771.

We were using `Object.create` to setup the prototype chain at the start of the class definition, which lead to #7771.

I was a bit worried about a speed hit, but it seems everyone optimizes the two patterns the same way.
https://jsbench.github.io/#f9fca52407643d96458a35763b201215

Fixes #7771.
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Apr 21, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7667/

1 similar comment
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Apr 21, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7667/

@hzoo
hzoo approved these changes Apr 21, 2018
@jridgewell jridgewell merged commit f8ab946 into babel:master Apr 21, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.84% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jridgewell jridgewell deleted the jridgewell:late-define-subclass-inheritance branch Apr 21, 2018
jridgewell added a commit to jridgewell/babel that referenced this pull request Apr 22, 2018
jridgewell added a commit to jridgewell/babel that referenced this pull request Apr 22, 2018
jridgewell added a commit to jridgewell/babel that referenced this pull request Apr 22, 2018
jridgewell added a commit that referenced this pull request Apr 22, 2018
* Update super property get/set/call in loose mode

Follows the plan laid out in #7553 (comment).

With #7691, this closes #7553, closes #4312.

* Post #7772

* Memoized property
jridgewell added a commit to jridgewell/babel that referenced this pull request May 18, 2018
jridgewell added a commit to jridgewell/babel that referenced this pull request May 18, 2018
jridgewell added a commit to jridgewell/babel that referenced this pull request May 18, 2018
hzoo added a commit that referenced this pull request May 23, 2018
* Revert "Move subclass inheritance to end (#7772)"

This reverts commit f8ab946.

* Only use getPrototypeOf if setPrototypeOf is implemented

* Update fixtures

* Helpers updates

* Update fixtures

* Fall back to getPrototypeOf

* Update fixtures
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.