Move subclass inheritance to end #7772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using `Object.create` to setup the prototype chain at the start of the class definition, which lead to babel#7771. I was a bit worried about a speed hit, but it seems everyone optimizes the two patterns the same way. https://jsbench.github.io/#f9fca52407643d96458a35763b201215 Fixes babel#7771.
jridgewell
added
the
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7667/ |
1 similar comment
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7667/ |
nicolo-ribaudo
approved these changes
Apr 21, 2018
hzoo
approved these changes
Apr 21, 2018
jridgewell
added a commit
to jridgewell/babel
that referenced
this pull request
Apr 22, 2018
jridgewell
added a commit
to jridgewell/babel
that referenced
this pull request
Apr 22, 2018
jridgewell
added a commit
to jridgewell/babel
that referenced
this pull request
Apr 22, 2018
jridgewell
added a commit
that referenced
this pull request
Apr 22, 2018
* Update super property get/set/call in loose mode Follows the plan laid out in #7553 (comment). With #7691, this closes #7553, closes #4312. * Post #7772 * Memoized property
jridgewell
added a commit
to jridgewell/babel
that referenced
this pull request
May 18, 2018
This reverts commit f8ab946.
jridgewell
added a commit
to jridgewell/babel
that referenced
this pull request
May 18, 2018
This reverts commit f8ab946.
jridgewell
added a commit
to jridgewell/babel
that referenced
this pull request
May 18, 2018
This reverts commit f8ab946.
hzoo
pushed a commit
that referenced
this pull request
May 23, 2018
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
Object.createto setup the prototype chain at the start of the class definition, which lead to #7771.I was a bit worried about a speed hit, but it seems everyone optimizes the two patterns the same way.
https://jsbench.github.io/#f9fca52407643d96458a35763b201215
Fixes #7771.